Repository navigation
gh-158856: Fix enum membership for values of a different hashability - #160576
Open
tonghuaroot wants to merge 1 commit into
Open
tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
…ility Since _hashable_values_ became a set, `value in EnumClass` missed values equal to a member value but of a different hashability, including a set member's own value. Check the unhashable values on a miss and compare against the hashable values on TypeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #159250 made
_hashable_values_a set,value in EnumClassreturnsFalsefor a value that equals a member value but has a different hashability. Asetvalue is not found even for its own member:set.__contains__()looks up asetkey as afrozensetinstead of raisingTypeError, so the list of unhashable values is never checked.Check the unhashable values whenever the set lookup misses, and compare against the hashable values on
TypeError. The regression is not in a release, so there is no NEWS entry._hashable_values_list scan) #158856